Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HDDS-12030. Update SCM-HA.zh.md #7669

Merged
merged 6 commits into from
Jan 21, 2025
Merged

HDDS-12030. Update SCM-HA.zh.md #7669

merged 6 commits into from
Jan 21, 2025

Conversation

jojochuang
Copy link
Contributor

What changes were proposed in this pull request?

HDDS-12030. Update SCM-HA.zh.md

Please describe your PR in detail:

  • Incorporates the doc update in HDDS-9897
  • Updated SCM HA docs regarding SCM HA enablement.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-12030

How was this patch tested?

Doc only

@jojochuang
HDDS-12030. Update SCM-HA.zh.md
6c69abc 
Change-Id: I0d7cf24c00aab38148e9ffd3e6e38d98e9beb318
nandakumar131
nandakumar131 reviewed Jan 9, 2025
View reviewed changes
hadoop-hdds/docs/content/feature/SCM-HA.md Outdated Show resolved Hide resolved
hadoop-hdds/docs/content/feature/SCM-HA.md Outdated Show resolved Hide resolved
hadoop-hdds/docs/content/feature/SCM-HA.md Outdated Show resolved Hide resolved
jojochuang and others added 3 commits January 9, 2025 13:52
@jojochuang @nandakumar131
Update hadoop-hdds/docs/content/feature/SCM-HA.md
6357307 
Co-authored-by: Nandakumar Vadivelu <[email protected]>
@jojochuang @nandakumar131
Update hadoop-hdds/docs/content/feature/SCM-HA.md
5b64416 
Co-authored-by: Nandakumar Vadivelu <[email protected]>
@jojochuang
Update Chiinese doc.
2f94bc7 
Change-Id: Iaec7a7ada558ea251d362c6d3b687a252469ec93
@ChenSammi
Copy link
Contributor

There is a typo "all the Datanodes" in the English version
Datanodes are sending all the reports (Container reports, Pipeline reports...) to *all* the Datanodes parallel.

For "### Current SCM HA Security limitation", I think we can remove the first item, and change the second item to
"Un-secure HA cluster upgrade to secure HA cluster is not supported."

@jojochuang
Fix typo
5191cbc 
Change-Id: I6d91479a181942d48837ea1c0d5a887f22469947
@jojochuang jojochuang marked this pull request as ready for review January 15, 2025 09:57
@adoroszlai adoroszlai added the documentation Improvements or additions to documentation label Jan 15, 2025
@jojochuang
Copy link
Contributor Author

All review comments are address. Please let me know if anything else is required. Thanks!

@jojochuang
Fix typos and remove outdated descriptions
f21fd0a 
Change-Id: Ib8297f80bf2e35bab65151128c0b999c817edf42
@jojochuang jojochuang requested a review from ChenSammi January 21, 2025 01:43
ChenSammi
ChenSammi approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@ChenSammi ChenSammi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jojochuang .

@ChenSammi ChenSammi merged commit 7b4df04 into apache:master Jan 21, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slfan1989 slfan1989 slfan1989 approved these changes

@ChenSammi ChenSammi ChenSammi approved these changes

@kaijchen kaijchen Awaiting requested review from kaijchen

@nandakumar131 nandakumar131 Awaiting requested review from nandakumar131

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jojochuang @ChenSammi @nandakumar131 @slfan1989 @adoroszlai